feat: implement atomic transaction safety for core services - #164
Merged
Conversation
Contributor
|
@Caritajoe18 Pls fix the conflict |
Contributor
Author
|
hello @ONEONUORA , |
ONEONUORA
approved these changes
Feb 24, 2026
ONEONUORA
left a comment
ONEONUORA
left a comment
Contributor
There was a problem hiding this comment.
Nice implementation @Caritajoe18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor AuditLogService and NotificationService to support database transactions.
Update create_plan, claim_plan, and update_kyc_status to use atomic rollback logic.
Add submit_kyc to the atomic flow and introduce audit_action::KYC_SUBMITTED constant.
Remove create_silent to ensure notification failures trigger transaction rollbacks.
Fix PgExecutor trait bound errors by using generic Executor<'a, Database = Postgres> for service helpers.
Resolve clippy::explicit-auto-deref by using idiomatic re-borrowing (&mut *tx) where required for trait satisfaction.
Update Axum handlers to align with new service signatures.
Rebased to merge conflicts
Closes #124"